Skip to content

Improve code analysis severity/suppress info #22534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 28, 2021
Merged

Improve code analysis severity/suppress info #22534

merged 5 commits into from
Jan 28, 2021

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Jan 27, 2021 •
edited
Loading

Fixes #21692, fixes #21132.

Preview links:

  • Language rules
  • CA2007 - this is just one rule; if approved, I'll add the "Suppress a warning" section via include file to each CA rule.

@dotnet-bot dotnet-bot added this to the January 2021 milestone Jan 27, 2021
@gewarren gewarren requested review from a team and mavasani January 27, 2021 21:09
@gewarren
Copy link
Contributor Author

@Youssef1313 Do you want to take a look?

Youssef1313
Youssef1313 reviewed Jan 27, 2021
View reviewed changes
Youssef1313
Youssef1313 approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with a small comment about more clarification. Feel free if you want to keep this in a follow-up.

@gewarren gewarren marked this pull request as ready for review January 28, 2021 00:55
@gewarren gewarren merged commit a3b41eb into dotnet:master Jan 28, 2021
@gewarren gewarren deleted the suppressss branch January 28, 2021 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Youssef1313 Youssef1313 Youssef1313 approved these changes

+1 more reviewer

@mavasani mavasani mavasani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

January 2021

Development

Successfully merging this pull request may close these issues.

Incorrect name/value pair ':severity' suffix in option value specification is now optional

4 participants

@gewarren @mavasani @Youssef1313 @dotnet-bot